Re: Allowing line-continuation in pgbench custom scripts - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Allowing line-continuation in pgbench custom scripts
Date
Msg-id 20140526153752.GY7857@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: Allowing line-continuation in pgbench custom scripts  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: Allowing line-continuation in pgbench custom scripts
List pgsql-hackers
Amit Langote wrote:
> On Mon, May 26, 2014 at 10:59 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> > On Mon, May 26, 2014 at 6:50 PM, Amit Langote <amitlangote09@gmail.com> wrote:
> >> Thoughts?
> >
> > IMO it's better if we can write SQL in multiples line *without* a tailing
> > escape character, like psql's input file.
> 
> Yeah, that would be much cleaner.

But that would require duplicating the lexing stuff to determine where
quotes are and where commands end.  There are already some cases where
pgbench itself is the bottleneck; adding a lexing step would be more
expensive, no?  Whereas simply detecting line continuations would be
cheaper.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: pg_llog not mentioned in "Database File Layout"
Next
From: Tom Lane
Date:
Subject: Re: Allowing line-continuation in pgbench custom scripts