Re: -DDISABLE_ENABLE_ASSERT - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: -DDISABLE_ENABLE_ASSERT
Date
Msg-id 20140522210013.GU7857@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: -DDISABLE_ENABLE_ASSERT  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: -DDISABLE_ENABLE_ASSERT
List pgsql-hackers
Andres Freund wrote:
> On 2014-05-22 16:37:35 -0400, Tom Lane wrote:

> > We could do that ... but I wonder if we shouldn't remove assert_enabled
> > altogether.  What's the use case for turning it off?  Not matching the
> > speed of a non-cassert build, because for instance MEMORY_CONTEXT_CHECKING
> > doesn't get turned off.
> 
> I've used it once or twice to avoid having to recompile postgres when I
> wanted things not to be *that* slow (AtEOXactBuffers() I am looking at
> you). But I wouldn't be very sad if it'd go.
> 
> Anybody against that?

I have used it too (for a different reason IIRC), but like you I
wouldn't have a problem if it weren't there.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: -DDISABLE_ENABLE_ASSERT
Next
From: Tomonari Katsumata
Date:
Subject: Re: 9.4 release notes