Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Writing changes of decoding plugin in the memory context where data is kept? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Writing changes of decoding plugin in the memory context where data is kept?
Date
Msg-id 20140515001838.GK23943@awork2.anarazel.de
Whole thread Raw
In response to [PATCH] Writing changes of decoding plugin in the memory context where data is kept?  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [PATCH] Writing changes of decoding plugin in the memory context where data is kept?  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view 
On 2014-05-15 09:11:15 +0900, Michael Paquier wrote:
> When working on a decoder plugin, I have been pointed that it is
> incorrect to write changes in an output plugin while not being in the
> memory context where changes are written.

That was a misunderstanding. It's perfectly alright to do so. The 'bug'
you have is that you sometimes wrote empty messages. Which
pg_recvlogical doesn't accept. There's little reason to allow doing so,
but for consistency we could probably ok to allow it.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cache invalidation bug in RelationGetIndexAttrBitmap()
Next
From: Tomas Vondra
Date:
Subject: Re: buildfarm / handling (undefined) locales