Re: pgsql: Revive line type - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Revive line type
Date
Msg-id 20140512232121.GB16042@momjian.us
Whole thread Raw
In response to Re: pgsql: Revive line type  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Revive line type  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Mon, May  5, 2014 at 01:24:15PM -0400, Tom Lane wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
> > On 2013-10-10 02:43:20 +0000, Peter Eisentraut wrote:
> >> Revive line type
>
> > That commit missed to update pg_type.h to the changed length of the line
> > type. Patch attached.
>
> Ouch.  Good thing we caught this now.
>
> In principle, fixing this breaks pg_upgrade'ability for anyone who was
> using the line type before (presumably by compiling with
> -DENABLE_LINE_TYPE).  However, we're breaking things for them anyway by
> changing the text representation, so that's probably not worth worrying
> over.

Should this be listed in the 9.4 release notes?  We didn't have _any_
line type before unless you -D/enabled it?  Our release notes say:

        Fully-implement the <link
        linkend="datatype-line"><type>line</></link> data type (Peter
        Eisentraut)

Is this text misleading?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Replace SYSTEMQUOTEs with Windows-specific wrapper functions.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Revive line type