Re: pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-( - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(
Date
Msg-id 20140428134708.GG25695@eldon.alvh.no-ip.org
Whole thread Raw
In response to pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> Can't completely get rid of #ifndef FRONTEND in palloc.h :-(
>
> pg_controldata includes postgres.h not postgres_fe.h, so utils/palloc.h
> must be able to compile in a "#define FRONTEND" context.

Hmm, I had this patch in an abandoned branch from long ago, which I
think helped remove postgres.h from pg_controldata.  I remembered it
just now because of this commit message.  Maybe it's useful to re-remove
the #ifndef FRONTEND from palloc.h.

It's not rebased to latest master and maybe even not complete; if people
think this approach is worthwhile I can try and clean it up and
proposely more seriously; LMK.  (Also if people think it needs futher
tweaks.  I vaguely recall I didn't propose it back then because the set
of stuff in the new header could be tweaked.)

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(
Next
From: Robert Haas
Date:
Subject: pgsql: Minor fixes for ALTER TABLE documentation.