Re: shouldn't we log permission errors when accessing the configured trigger file? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: shouldn't we log permission errors when accessing the configured trigger file?
Date
Msg-id 20140417155615.GG7443@momjian.us
Whole thread Raw
In response to Re: shouldn't we log permission errors when accessing the configured trigger file?  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Wed, Apr 16, 2014 at 06:55:14PM -0400, Bruce Momjian wrote:
> >     Seems reasonable.  It could lead to quite a bit of log spam, I
> >     suppose, but the way things are now could be pretty mystifying if
> >     you've located your trigger file somewhere outside $PGDATA, and a
> >     parent directory is lacking permissions.
> > 
> > 
> > +1. Since it actually indicates something that's quite broken (since with that
> > you can never make the trigger work until you fix it), the log spam seems like
> > it would be appropriate. (Logspam is never nice, but a single log line is also
> > very easy to miss - this should log enough that you wouldn't) 
> 
> I have developed the attached patch to address this issue.

Patch applied.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Verbose output of pg_dump not show schema name
Next
From: Stephen Frost
Date:
Subject: Re: Clock sweep not caching enough B-Tree leaf pages?