Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0
Date
Msg-id 20140416234806.GT7443@momjian.us
Whole thread Raw
In response to Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Wed, Apr 16, 2014 at 11:22:28AM -0400, Bruce Momjian wrote:
> On Fri, Apr 11, 2014 at 08:28:55AM -0400, Bruce Momjian wrote:
> > Once this is applied I will work on changing the libpq socket type to
> > use portable pgsocket, but I am not planning to backpatch that unless we
> > find a bug.
> 
> Attached is a follow up patch which stores socket values in libpq as
> pgsocket, rather than int, and maps it to -1 only for the PQsocket()
> external return value.  In the interest of time, I will apply this later
> today, and only to head as it does not fix a bug.
> 
> This is the last open item I was working on.

Applied.  FYI, Joel Jacobson was the initial author of this thread of
patches;  report by PVS-Studio.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Minor performance improvement in transition to external sort
Next
From: Bruce Momjian
Date:
Subject: Re: [GENERAL] client encoding that psql command sets