Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0
Date
Msg-id 20140416134856.GA7443@momjian.us
Whole thread Raw
In response to Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Wed, Apr 16, 2014 at 10:34:55AM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > 
> > Yes, I saw that yesterday and fixed it.  I also did a dry run of
> > backpatching and only 8.4 had conflicts, so I think we are good there.
> > (This is like the readdir() fix all over again.)
> > 
> > Once this is applied I will work on changing the libpq socket type to
> > use portable pgsocket, but I am not planning to backpatch that unless we
> > find a bug.
> 
> Are we done with this patch?

I am about to patch it now.   I was going to do it yesterday but was
concerned I wouldn't be online long enough to catch any buildfarm
failure.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Clock sweep not caching enough B-Tree leaf pages?
Next
From: Marco Atzeri
Date:
Subject: Re: test failure on latest source