On Thu, Apr 10, 2014 at 01:10:35PM -0400, Bruce Momjian wrote:
> On Thu, Apr 10, 2014 at 01:05:32PM -0400, Greg Stark wrote:
> > If it's conditional I think "when it matches a guc" is too hard for users to
> > use.
>
> Yes, we gave up on having the OID display match the GUC; we just
> display something if and only if it oids are present.
>
> Robert is talking about the "Identity Replica" display, which is new in
> 9.4 and should match how we display oids. Right now "Identity Replica"
> only displays something if the user changed the default.
>
> > I think "say nothing if oids are off and say something of their on" would be
> > fine. It would result in clutter for users which oids on by default but that's
> > a non default setting.
>
> Yes, that is what the proposed patch does.
I talked to Robert via voice to understand his concerns. He clearly
explained the complexity of how "Replica Identity" is set. I, of
course, am concerned about user confusion in showing these values.
What I did was develop the attached patch which clarifies the default
for system and non-system tables, documents when psql displays it, and
improves the display for pg_catalog tables that aren't equal to NONE.
It also has changed the OID status to only display if it exists. One
question that came up with Robert is whether OID status should appear
for \d as well, now that is only shows up when present.
I am hopeful this patch is closer to general agreement.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
