quiet inline configure check misses a step for clang - Mailing list pgsql-hackers

From Andres Freund
Subject quiet inline configure check misses a step for clang
Date
Msg-id 20140403104700.GX3750@awork2.anarazel.de
Whole thread Raw
Responses Re: quiet inline configure check misses a step for clang  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: quiet inline configure check misses a step for clang  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Hi,

The current quiet inline test doesn't work for clang. As e.g. evidenced in
http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=gull&dt=2014-04-03%2007%3A49%3A26&stg=configure
configure thinks it's not quiet.

Which means that postgres compiled with a recent clang will be noticably
slower than it needs to be.

The reason for that is that clang is smart and warns about static inline
if they are declared locally in the .c file, but not if they are
declared in a #included file.  That seems to be a reasonable
behaviour...

I think that needs to be fixed. We either can make the configure test
considerably more complex or simply drop the requirement for quiet
inline.

Comments?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: GSoC proposal - "make an unlogged table logged"
Next
From: Heikki Linnakangas
Date:
Subject: Re: GSoC proposal - "make an unlogged table logged"