Re: Comment - uniqueness of relfilenode - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Comment - uniqueness of relfilenode
Date
Msg-id 20140308172044.GC4690@momjian.us
Whole thread Raw
In response to Re: Comment - uniqueness of relfilenode  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Thu, Mar  6, 2014 at 09:20:39PM -0500, Bruce Momjian wrote:
> On Thu, Mar  6, 2014 at 08:34:29AM +0100, Antonin Houska wrote:
> > >>> You're right. I missed the fact that Postgres (unlike another DBMS that
> > >>> I worked with) allows for tablespace to be shared across databases.
> > >>
> > >> I have update the C comment:
> > >>
> > >>         <  * Notice that relNode is only unique within a particular database.
> > >>         ---
> > >>         >  * Notice that relNode is only unique within a particular tablespace.
> > > 
> > > Yep. But the new text is no more correct than the old text.  Did you
> > > read what I wrote upthread?
> > 
> > Perhaps "... unique within a particular (tablespace, database)
> > combination." ?
> 
> Oh, I thought people just wanted the text to be consistent with other
> mentions, rather than improving it.  Attached is a patch which updates
> comments about the tablespace/database issue.

Applied.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_ctl status with nonexistent data directory
Next
From: Bruce Momjian
Date:
Subject: Re: Improve timestamp substraction to be DST-aware