Re: Changeset Extraction v7.9.1 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Changeset Extraction v7.9.1
Date
Msg-id 20140307131721.GC4759@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: Changeset Extraction v7.9.1  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Changeset Extraction v7.9.1  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Andres Freund escribió:

>              fprintf(stderr,
> -                    _("%s: could not identify system: got %d rows and %d fields, expected %d rows and %d
fields\n"),
> -                    progname, PQntuples(res), PQnfields(res), 1, 3);
> +                    _("%s: could not identify system: got %d rows and %d fields, expected 1 row and 3 or more
fields\n"),
> +                    progname, PQntuples(res), PQnfields(res));

Please don't change this.  The reason these messages use %d and an extra
printf argument is to avoid giving translators extra work when the
number of rows or fields is changed.  In these cases I suggest this:

> -                    _("%s: could not identify system: got %d rows and %d fields, expected %d rows and %d
fields\n"),
> -                    progname, PQntuples(res), PQnfields(res), 1, 3);
> +                    _("%s: could not identify system: got %d rows and %d fields, expected %d rows and %d or more
fields\n"),
> +                    progname, PQntuples(res), PQnfields(res), 1, 3);

(Yes, I know the "expected 1 rows" output looks a bit silly.  Since this
is an unexpected error message anyway, I don't think that's worth
fixing.)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Changeset Extraction v7.9.1
Next
From: Robert Haas
Date:
Subject: Re: GSoC on WAL-logging hash indexes