Re: pg_ctl status with nonexistent data directory - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_ctl status with nonexistent data directory
Date
Msg-id 20140307041108.GF11419@momjian.us
Whole thread Raw
In response to Re: pg_ctl status with nonexistent data directory  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: pg_ctl status with nonexistent data directory  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Fri, Mar  7, 2014 at 09:07:24AM +0530, Amit Kapila wrote:
> One reason could be that as we are already returning special exit code
> for 'status' option of pg_ctl (exit(3)), this seems to be inline with it as this
> also get called during status command.
>
> Also in the link sent by you in another mail, I could see some statement
> which indicates it is more important to return correct codes in case of
> status which sounds a good reason to me.
>
> Link and statement
> http://www.postgresql.org/message-id/51D1E482.5090602@gmx.net
>
> "The "status" case is different, because there the exit code
> can be passed out by the init script directly."
>
> If we just want to handle correct exit codes for "status" option, then
> may be we need to refactor the code a bit to ensure the same.

OK, done with the attached patch  Three is returned for status, but one
for other cases.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_ctl status with nonexistent data directory
Next
From: Bruce Momjian
Date:
Subject: Re: jsonb and nested hstore