Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0
Date
Msg-id 20140305192422.GS4759@eldon.alvh.no-ip.org
Whole thread Raw
In response to [BUG FIX] Compare returned value by socket() against PGINVALID_SOCKET instead of < 0  (Joel Jacobson <joel@trustly.com>)
List pgsql-hackers
Joel Jacobson wrote:
> Hi,
> 
> I've tried to fix some bugs reported by Andrey Karpov in an article at
> http://www.viva64.com/en/b/0227/
> 
> The value returned by socket() is unsigned on Windows and can thus not
> be checked if less than zero to detect an error, instead
> PGINVALID_SOCKET should be used, which is hard-coded to -1 on
> non-windows platforms.

Can I bug you into verifying what supported releases need this patch,
and to which does it backpatch cleanly?  And if there's any to which it
doesn't, can I further bug you into providing one that does?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Custom Scan APIs (Re: Custom Plan node)
Next
From: Bruce Momjian
Date:
Subject: Re: jsonb and nested hstore