Re: Another possible corruption bug in 9.3.2 or possibly a known MultiXact problem? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Another possible corruption bug in 9.3.2 or possibly a known MultiXact problem?
Date
Msg-id 20140226222646.GE6718@awork2.anarazel.de
Whole thread Raw
In response to Re: Another possible corruption bug in 9.3.2 or possibly a known MultiXact problem?  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Another possible corruption bug in 9.3.2 or possibly a known MultiXact problem?  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 2014-02-26 18:18:05 -0300, Alvaro Herrera wrote:
> Andres Freund wrote:
> 
> > static void
> > heap_xlog_lock(XLogRecPtr lsn, XLogRecord *record)
> > {
> > ...
> >     HeapTupleHeaderClearHotUpdated(htup);
> >     HeapTupleHeaderSetXmax(htup, xlrec->locking_xid);
> >     HeapTupleHeaderSetCmax(htup, FirstCommandId, false);
> >     /* Make sure there is no forward chain link in t_ctid */
> >     htup->t_ctid = xlrec->target.tid;
> > ...
> > }
> 
> I think the fix is to reset HOT_UPDATED and t_ctid only if the infomask
> says the tuple is LOCKED_ONLY, per the attached patch.

Looks good to me.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Another possible corruption bug in 9.3.2 or possibly a known MultiXact problem?
Next
From: Andres Freund
Date:
Subject: Re: jsonb and nested hstore