Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication - Mailing list pgsql-hackers

Hi,

On 21/02/14 13:49, Andres Freund wrote:
> If we're going this route - which I am ok with - I'd suggest for doing
> something like:
>
> > -                PgBackendStatus *be = pgstat_fetch_stat_beentry(i);
> > +                LocalPgBackendStatus *lbe = pgstat_fetch_stat_local_beentry(i);
> > +                PgBackendStatus *be = &lb->backendStatus;
>
> There seems little point in making all those lines longer and the
> accompanying diff noise if all it costs is a local variable.
>
> Makes sense?

Makes sense, good idea. Attached you will find a new version of the
patch.

Best regards,

--
 Christian Kruse               http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services