Postgres Pro
Downloads
Home   >   mailing lists

Re: CREATE FOREIGN TABLE ( ... LIKE ... ) - Mailing list pgsql-hackers

From Andres Freund
Subject Re: CREATE FOREIGN TABLE ( ... LIKE ... )
Date
Msg-id 20140217222247.GI7161@awork2.anarazel.de
Whole thread Raw
In response to Re: CREATE FOREIGN TABLE ( ... LIKE ... )  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: CREATE FOREIGN TABLE ( ... LIKE ... )  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view 
On 2014-02-17 23:07:45 +0900, Michael Paquier wrote:
> On Mon, Feb 17, 2014 at 6:28 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> > I don't think this really has gone above Needs Review yet.
> I am not sure that this remark makes the review of this patch much
> progressing :(
> 
> By the way, I spent some time looking at it and here are some
> comments:

David just pinged me and tricked me into having a quick look :)

Unless I miss something this possibly allows column definition to slip
by that shouldn't because normally all fdw column definitions are passed
through transformColumnDefinition() which does some checks, but the
copied ones aren't.
I haven't looked long enough to see whether that's currently
problematic, but even if not, it's sure a trap waiting to spring.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: patch: option --if-exists for pg_dump
Next
From: Bjorn Munch
Date:
Subject: Re: Ctrl+C from sh can shut down daemonized PostgreSQL cluster