Postgres Pro
Downloads
Home   >   mailing lists

Re: [bug fix] pg_ctl fails with config-only directory - Mailing list pgsql-hackers

From Christian Kruse
Subject Re: [bug fix] pg_ctl fails with config-only directory
Date
Msg-id 20140130082046.GD3557@defunct.ch
Whole thread Raw
In response to Re: [bug fix] pg_ctl fails with config-only directory  ("MauMau" <maumau307@gmail.com>)
Responses Re: [bug fix] pg_ctl fails with config-only directory  ("MauMau" <maumau307@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

personally I really dislike constructs like you used:

#ifdef WIN32if (check_if_admin)
#endif    check_root(progname);

It is hard to read and may confuse editors. Can you rewrite it?

The rest looks fine to me.

Best regards,

-- Christian Kruse               http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: Row-security on updatable s.b. views
Next
From: Christian Kruse
Date:
Subject: Re: Regression tests failing if not launched on db "regression"