Re: A minor correction in comment in heaptuple.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: A minor correction in comment in heaptuple.c
Date
Msg-id 20140128172551.GQ10723@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: A minor correction in comment in heaptuple.c  (Bruce Momjian <bruce@momjian.us>)
Responses Re: A minor correction in comment in heaptuple.c
List pgsql-hackers
Bruce Momjian escribió:
> On Tue, Jan 28, 2014 at 11:20:39AM -0500, Tom Lane wrote:
> > Andres Freund <andres@2ndquadrant.com> writes:
> > > On 2014-01-28 11:14:49 -0500, Bruce Momjian wrote:
> > >> OK, so does anyone object to removing this comment line?
> > 
> > > Let's just not do anything. This is change for changes sake. Not
> > > improving anything the slightest.
> > 
> > Indeed.  I'd actually request that you revert your previous change to the
> > comment, as it didn't improve matters and is only likely to cause pain for
> > future back-patching.
> 
> OK, so we have a don't change anything and a revert. I am thinking the
> new wording as a super-minor improvement.  Anyone else want to vote?

I vote to revert to the original and can we please wait for longer than
a few hours on a weekend before applying this kind of change that is
obviously not without controversy.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe
Next
From: Bruce Momjian
Date:
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe