Re: Add %z support to elog/ereport? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Add %z support to elog/ereport?
Date
Msg-id 20140118003352.GC22416@awork2.anarazel.de
Whole thread Raw
In response to Re: Add %z support to elog/ereport?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add %z support to elog/ereport?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2014-01-17 13:50:08 -0500, Tom Lane wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
> > [ 0001-Add-support-for-printing-Size-arguments-to-elog-erep.patch ]
> 
> I think this approach is fundamentally broken, because it can't reasonably
> cope with any case more complicated than "%zu" or "%zd".  While it's
> arguable that we can get along without the ability to specify field width,
> since the [U]INT64_FORMAT macros never allowed that, it is surely going
> to be the case that translators will need to insert "n$" flags in the
> translated versions of messages.

Am I just too tired, or am I not getting how INT64_FORMAT currently
allows the arguments to be used posititional?

Admittedly most places currently just cast down the value avoiding the
need for INT64_FORMAT in many places.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Add %z support to elog/ereport?
Next
From: Andres Freund
Date:
Subject: Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance (summary v2 2014-1-17)