Re: [PATCH] Relocation of tablespaces in pg_basebackup - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Relocation of tablespaces in pg_basebackup
Date
Msg-id 20140116142559.GG4554@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCH] Relocation of tablespaces in pg_basebackup  (Steeve Lennmark <steevel@handeldsbanken.se>)
Responses Re: [PATCH] Relocation of tablespaces in pg_basebackup  (Andres Freund <andres@2ndquadrant.com>)
Re: [PATCH] Relocation of tablespaces in pg_basebackup  (Steeve Lennmark <steevel@handeldsbanken.se>)
List pgsql-hackers
Eyeballing this patch, three thoughts:

1. I wonder whether ilist.c/h should be moved to src/common so that
frontend code could use it.

2. I wonder whether ilist.c should gain the ability to have
singly-linked lists with a pointer to the tail node for appending to the
end.  This code would use it, and also the code doing postgresql.conf
parsing which has head/tail pointers all over the place.  I'm sure there
are other uses.

3. How many definitions of atooid() do we have now?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: WAL Rate Limiting
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] Relocation of tablespaces in pg_basebackup