Re: Add %z support to elog/ereport? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Add %z support to elog/ereport?
Date
Msg-id 20140115195325.GE8653@awork2.anarazel.de
Whole thread Raw
In response to Re: Add %z support to elog/ereport?  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On 2013-12-08 01:32:45 +0100, Andres Freund wrote:
> On 2013-12-06 09:54:59 -0500, Peter Eisentraut wrote:
> > On 11/11/13, 12:01 PM, Tom Lane wrote:
> > > I do recall Peter saying that the infrastructure knows how to
> > > verify conversion specs in translated strings, so it would have to be
> > > aware of 'z' flags for this to work.
> > 
> > It just checks that the same conversion placeholders appear in the
> > translation.  It doesn't interpret the actual placeholders.  I don't
> > think this will be a problem.
> 
> Ok, so here's a patch.
> 
> Patch 01 introduces infrastructure, and elog.c implementation.
> Patch 02 converts some elog/ereport() callers to using the z modifier,
>       some were wrong at least on 64 bit windows.

There's just been another instance of printing size_t values being
annoying, reminding me of this patch. I'll add it to the current
commitfest given I've posted it over a month ago unless somebody
protests?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Why conf.d should be default, and auto.conf and recovery.conf should be in it
Next
From: "Erik Rijkers"
Date:
Subject: Re: tests for client programs