Re: Patch - Re: [HACKERS] view vs. inheritance hierarchy - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch - Re: [HACKERS] view vs. inheritance hierarchy
Date
Msg-id 20140.941389198@sss.pgh.pa.us
Whole thread Raw
In response to Patch - Re: [HACKERS] view vs. inheritance hierarchy  (Karel Zak - Zakkr <zakkr@zf.jcu.cz>)
Responses Re: Patch - Re: [HACKERS] view vs. inheritance hierarchy
List pgsql-hackers
Karel Zak - Zakkr <zakkr@zf.jcu.cz> writes:
> *** ruleutils.c.org    Mon Sep  6 00:55:28 1999
> --- ruleutils.c    Sun Sep 31 13:37:42 1999
> ***************
> *** 968,971 ****
> --- 968,973 ----
>                   strcat(buf, "\"");
>                   strcat(buf, rte->relname);
> +                 if (rte->inh)
> +                     strcat(buf, "*");
>                   strcat(buf, "\"");
>                   if (strcmp(rte->relname, rte->refname) != 0)
> ***************
> *** 973,976 ****
> --- 975,980 ----
>                       strcat(buf, " \"");
>                       strcat(buf, rte->refname);
> +                     if (rte->inh)
> +                         strcat(buf, "*");
>                       strcat(buf, "\"");
>                   }

>  Add we (Jan or Tom) this code to PostgreSQL source main? (Pease).

That looks about like the right thing to do, but I wonder whether the
"*" doesn't need to go *outside* the quote marks around the table name?
Seems like it would be taken as a name character if inside...
        regards, tom lane


pgsql-hackers by date:

Previous
From: Karel Zak - Zakkr
Date:
Subject: Patch - Re: [HACKERS] view vs. inheritance hierarchy
Next
From: "Andrij Korud"
Date:
Subject: Trigger aborted on error