Re: PoC: Partial sort - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: PoC: Partial sort
Date
Msg-id 20131231132253.GV22570@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: PoC: Partial sort  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
David Rowley escribió:

> I was about to test it tonight, but I'm having trouble getting the patch to
> compile... I'm really wondering which compiler you are using as it seems
> you're declaring your variables in some strange places.. See nodeSort.c
> line 101. These variables are declared after there has been an if statement
> in the same scope. That's not valid in C. (The patch did however apply
> without any complaints).

AFAIR C99 allows mixed declarations and code.  Visual Studio only
implements C89 though, which is why it fails to compile there.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [PATCH] Store Extension Options
Next
From: Fabrízio de Royes Mello
Date:
Subject: Re: [PATCH] Store Extension Options