Re: clang's -Wmissing-variable-declarations shows some shoddy programming - Mailing list pgsql-hackers

From Andres Freund
Subject Re: clang's -Wmissing-variable-declarations shows some shoddy programming
Date
Msg-id 20131219230938.GD11483@alap2.anarazel.de
Whole thread Raw
In response to Re: clang's -Wmissing-variable-declarations shows some shoddy programming  (Kevin Grittner <kgrittn@ymail.com>)
Responses Re: clang's -Wmissing-variable-declarations shows some shoddy programming
List pgsql-hackers
On 2013-12-19 14:56:38 -0800, Kevin Grittner wrote:
> Bruce Momjian <bruce@momjian.us> wrote:
>
> > I have fixed the binary_upgrade_* variables defines, and Heikki has
> > fixed some other cases.  Can you rerun the test against git head and
> > post the updated output?  Thanks.
>
> I'm now seeing the attached.

Heh, too fast for me. I was just working on a patch to fix some of these
;)

The attached patch fixes some of the easiest cases, where either an
include was missing o a variable should have been static.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: clang's -Wmissing-variable-declarations shows some shoddy programming
Next
From: Florian Pflug
Date:
Subject: XML Issue with DTDs