Re: clang's -Wmissing-variable-declarations shows some shoddy programming - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: clang's -Wmissing-variable-declarations shows some shoddy programming
Date
Msg-id 20131219211144.GF1690@momjian.us
Whole thread Raw
In response to clang's -Wmissing-variable-declarations shows some shoddy programming  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: clang's -Wmissing-variable-declarations shows some shoddy programming
List pgsql-hackers
On Sat, Dec 14, 2013 at 04:52:28PM +0100, Andres Freund wrote:
> Hi,
> 
> Compiling postgres with said option in CFLAGS really gives an astounding
> number of warnings. Except some bison/flex generated ones, none of them
> looks acceptable to me.
> Most are just file local variables with a missing static and easy to
> fix. Several other are actually shared variables, where people simply
> haven't bothered to add the variable to a header. Some of them with
> comments declaring that fact, others adding longer comments, even others
> adding longer comments about that fact.
> 
> I've attached the output of such a compilation run for those without
> clang.

I have fixed the binary_upgrade_* variables defines, and Heikki has
fixed some other cases.  Can you rerun the test against git head and
post the updated output?  Thanks.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: clang's -Wmissing-variable-declarations shows some shoddy programming
Next
From: Robert Haas
Date:
Subject: Re: preserving forensic information when we freeze