Postgres Pro
Downloads
Home   >   mailing lists

Re: clang's -Wmissing-variable-declarations shows some shoddy programming - Mailing list pgsql-hackers

From Andres Freund
Subject Re: clang's -Wmissing-variable-declarations shows some shoddy programming
Date
Msg-id 20131219103842.GA1759@alap2.anarazel.de
Whole thread Raw
In response to Re: clang's -Wmissing-variable-declarations shows some shoddy programming  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Tree view 
Hi,

On 2013-12-18 22:11:03 -0500, Bruce Momjian wrote:
> Now that pg_upgrade has stabilized, I think it is time to centralize all
> the pg_upgrade_support control variables in a single C include file that
> can be used by the backend and by pg_upgrade_support.  This will
> eliminate the compiler warnings too.

Btw, I think it's more or less lucky the current state works at all -
there's missing PGDLLIMPORT statements on the builtin side...

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: GIN improvements part 1: additional information
Next
From: Andres Freund
Date:
Subject: Re: preserving forensic information when we freeze