Alvaro Herrera wrote:
> Well, it would help if those cases weren't dead code. Neither
> heap_update nor heap_delete are ever called in the "no wait" case at
> all. Only heap_lock_tuple is, and I can't see any misbehavior there
> either, even with HeapTupleBeingUpdated returned when there's a
> non-local locker, or when there's a MultiXact as xmax, regardless of its
> status.
I spent some more time trying to generate a test case that would show a
problem with the changed return values here, and was unable to.
I intend to apply this patch soon.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
