Re: logical changeset generation v6.8 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: logical changeset generation v6.8
Date
Msg-id 20131213111230.GG29402@awork2.anarazel.de
Whole thread Raw
In response to Re: logical changeset generation v6.8  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: logical changeset generation v6.8
List pgsql-hackers
On 2013-12-13 20:58:24 +1300, David Rowley wrote:
> On Wed, Dec 11, 2013 at 1:11 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> This introduced a new compiler warning on the visual studios build:
>   d:\postgres\b\src\backend\utils\cache\relcache.c(3958): warning C4715:
> 'RelationGetIndexAttrBitmap' : not all control paths return a value
> [D:\Postgres\b\postgres.vcxproj]
> 
> The attached patch fixes it.

I thought we'd managed to get elog(ERROR) properly annotated as noreturn
on msvc as well?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: "Etsuro Fujita"
Date:
Subject: Minor comment improvement
Next
From: Heikki Linnakangas
Date:
Subject: Bug in visibility map WAL-logging