Re: git diff --check whitespace checks, gitattributes - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: git diff --check whitespace checks, gitattributes
Date
Msg-id 20131106160429.GO5809@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: git diff --check whitespace checks, gitattributes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:

> (Actually I tend to pgindent stuff before committing, these
> days, but sometimes that's impractical because somebody's already
> committed some not-well-indented stuff elsewhere in the same file.)

What I normally do is commit the changes, then pgindent, then manually
review the pgindent changes (which are normally tiny because my editor
is configured to produce very similar results to pgindent, as I'm sure
yours is.)  Then I manually revert the parts not in my commit (also
eased by editor support).  Then I squash the commits.

This doesn't take very long.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Ants Aasma
Date:
Subject: Re: better atomics
Next
From: Peter Eisentraut
Date:
Subject: Re: pg_fallocate