Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry?
Date
Msg-id 20131105193632.GD14819@awork2.anarazel.de
Whole thread Raw
In response to Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry?  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry?  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On 2013-11-04 13:48:32 +0100, Andres Freund wrote:
> What about just unowning the smgr entry with
> if (rel->rd_smgr != NULL)
>    smgrsetowner(NULL, rel->rd_smgr)
> when closing the fake relcache entry?
>
> That shouldn't require any further changes than changing the comment in
> smgrsetowner() that this isn't something expected to frequently happen.

Attached is a patch doing it like that, it required slightmy more
invasive changes than that. With the patch applied we survive replay of
a primary's make check run under valgrind without warnings.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: List of "binary-compatible" data types
Next
From: Rajeev rastogi
Date:
Subject: TODO: Split out pg_resetxlog output into pre- and post-sections