Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] hstore_to_json: empty hstores must return empty json objects - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] hstore_to_json: empty hstores must return empty json objects
Date
Msg-id 20131017142320.GE9746@eldon.alvh.no-ip.org
Whole thread Raw
In response to [PATCH] hstore_to_json: empty hstores must return empty json objects  (Oskari Saarenmaa <os@ohmu.fi>)
Responses Re: [PATCH] hstore_to_json: empty hstores must return empty json objects
Re: [PATCH] hstore_to_json: empty hstores must return empty json objects
List pgsql-hackers
Tree view 
Oskari Saarenmaa wrote:

> @@ -1241,8 +1241,8 @@ hstore_to_json_loose(PG_FUNCTION_ARGS)
>  
>      if (count == 0)
>      {
> -        out = palloc(1);
> -        *out = '\0';
> +        out = palloc(3);
> +        memcpy(out, "{}", 3);
>          PG_RETURN_TEXT_P(cstring_to_text(out));
>      }

Can't you just PG_RETURN_TEXT_P(cstring_to_text("{}")) ?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] pg_sleep(interval)
Next
From: Oskari Saarenmaa
Date:
Subject: Re: [PATCH] hstore_to_json: empty hstores must return empty json objects