Re: unaccent module - two params function should be immutable - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: unaccent module - two params function should be immutable
Date
Msg-id 20130924213658.GB21534@momjian.us
Whole thread Raw
In response to Re: unaccent module - two params function should be immutable  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: unaccent module - two params function should be immutable
List pgsql-hackers
On Tue, Sep 17, 2013 at 10:15:47AM -0400, Robert Haas wrote:
> On Sat, Sep 14, 2013 at 9:42 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
> >> I have developed the attached patch based on your suggestion.  I did not
> >> see anything in the code that would make it STABLE, except a lookup of a
> >> dictionary library:
> >>
> >>         dictOid = get_ts_dict_oid(stringToQualifiedNameList("unaccent"),
> >> false);
> >
> > yes, it risk, but similar is with timezones, and other external data.
> 
> That's a catalog lookup - not a reliance on external data.

Sorry, I was wrong.  Only unaccent_dict() calls get_ts_dict_oid(), and
we aren't changing the signature of that function.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block
Next
From: Alvaro Herrera
Date:
Subject: Re: Minmax indexes