Re: [PATCH] Revive line type - Mailing list pgsql-hackers

From David Fetter
Subject Re: [PATCH] Revive line type
Date
Msg-id 20130916225703.GA24324@fetter.org
Whole thread Raw
In response to Re: [PATCH] Revive line type  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] Revive line type
List pgsql-hackers
On Mon, Sep 16, 2013 at 07:04:32PM -0300, Alvaro Herrera wrote:
> Peter Eisentraut escribió:
> > Here is a new patch for the line type, with a new input/output format
> > {A,B,C}, as discussed in this thread.
> 
> I gave this a quick look.  The new input/output format appears to work
> well.  The input format using two points still works, which is nice.
> Regression tests pass.  I tried binary input and output using COPY and
> it seems to round-trip without problem.
> 
> With the two-point input, horizontal and vertical lines can accept NaNs
> without producing a NaN in the output if not necessary.
> 
> I tried "interpt" and "intersect" functions and they seem to work.
> Haven't gotten around to trying other functions or operators.

Should the things you tried and others be in the regression tests?  If
so, should we start with whatever had been in the regression tests
when the line type was dropped?

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: record identical operator
Next
From: Alvaro Herrera
Date:
Subject: Re: Dead function argument?