Re: Strange hanging bug in a simple milter - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Strange hanging bug in a simple milter
Date
Msg-id 20130913190331.GY2706@tamriel.snowman.net
Whole thread Raw
In response to Re: Strange hanging bug in a simple milter  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Strange hanging bug in a simple milter
Re: Strange hanging bug in a simple milter
List pgsql-hackers
* Andres Freund (andres@2ndquadrant.com) wrote:
> It seems slightly cleaner to just move the pqsecure_destroy(); to the
> end of that function, based on a boolean. But if you think otherwise, I
> won't protest...

Hmm, agreed; I had originally been concerned that the SIGPIPE madness
needed to be around the pqsecure_destroy() call, but I can't see why
that would be.

I've run through a few times w/ the attached and haven't seen the
deadlock.  Will continue testing, of course.

Heikki, any thoughts regarding this change?  Any concerns about
back-patching it?

    Thanks,

        Stephen

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE
Next
From: Andrew Gierth
Date:
Subject: Re: UNNEST with multiple args, and TABLE with multiple funcs