Re: [RFC] overflow checks optimized away - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [RFC] overflow checks optimized away
Date
Msg-id 20130715215950.GA4165@eldon.alvh.no-ip.org
Whole thread Raw
In response to [RFC] overflow checks optimized away  (Xi Wang <xi.wang@gmail.com>)
Responses Re: [RFC] overflow checks optimized away
List pgsql-hackers
Xi Wang escribió:
> Intel's icc and PathScale's pathcc compilers optimize away several
> overflow checks, since they consider signed integer overflow as
> undefined behavior.  This leads to a vulnerable binary.

This thread died without reaching a conclusion.  Noah Misch, Robert Haas
and Greg Stark each gave a +1 to the patches, but Tom Lane gave them a
-inf; so they weren't applied.  However, I think everyone walked away
with the feeling that Tom is wrong on this.

Meanwhile Xi Wang and team published a paper:
http://pdos.csail.mit.edu/~xi/papers/stack-sosp13.pdf

Postgres is mentioned a number of times in this paper -- mainly to talk
about the bugs we leave unfixed.

It might prove useful to have usable these guys' STACK checker output
available continuously, so that if we happen to introduce more bugs in
the future, it alerts us about that.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]
Next
From: Robert Haas
Date:
Subject: Re: [RFC] overflow checks optimized away