Re: Review: query result history in psql - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Review: query result history in psql
Date
Msg-id 20130627175319.GH3757@eldon.alvh.no-ip.org
Whole thread Raw
In response to Re: Review: query result history in psql  (Maciej Gajewski <maciej.gajewski0@gmail.com>)
Responses Re: Review: query result history in psql
List pgsql-hackers
Maciej Gajewski escribió:

> > Those issues aside - I think it's a great feature! I can add the
> > grammatical fixes I made whenever the final patch is ready. Or earlier,
> > whatever works for you. Also, this is my first time reviewing a patch, so
> > please let me know if I can improve on anything. Thanks!
> 
> This is  my first submitted patch, so I can't really comment on the
> process. But if you could add the author's email to CC, the message would
> be much easier to spot. I replied after two days only because I missed the
> message in the flood of other pgsql-hacker messages. I think I need to scan
> the list more carefully...

It's better to post a review as a reply to the message which contains
the patch.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: XLogInsert scaling, revisited
Next
From: Tom Lane
Date:
Subject: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]