Re: Add more regression tests for dbcommands - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Add more regression tests for dbcommands
Date
Msg-id 20130626113406.GE8637@awork2.anarazel.de
Whole thread Raw
In response to Re: Add more regression tests for dbcommands  (Robins Tharakan <tharakan@gmail.com>)
Responses Re: Add more regression tests for dbcommands
Re: Add more regression tests for dbcommands
List pgsql-hackers
Hi,

I am generally a bit unsure whether the regression tests you propose
aren't a bit too verbose. Does any of the committers have an opinion
about this?

My feeling is that they are ok if they aren't slowing down things much.

On 2013-06-26 01:55:53 -0500, Robins Tharakan wrote:
> The CREATE DATABASE test itself was checking whether the 'CONNECTION LIMIT'
> was working. Removed that as well.

You should be able to test that by setting the connection limit to 1 and
then try to connect using \c. The old connection is only dropped after
the new one has been successfully performed.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Hash partitioning.
Next
From: Rushabh Lathia
Date:
Subject: Re: proposal 9.4 plpgsql: allows access to call stack from GET DIAGNOSTICS statement