Re: [PATCH] Remove useless USE_PGXS support in contrib - Mailing list pgsql-hackers

From Cédric Villemain
Subject Re: [PATCH] Remove useless USE_PGXS support in contrib
Date
Msg-id 201306171901.04730.cedric@2ndquadrant.com
Whole thread Raw
In response to Re: [PATCH] Remove useless USE_PGXS support in contrib  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] Remove useless USE_PGXS support in contrib  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Le lundi 17 juin 2013 18:41:32, Alvaro Herrera a écrit :
> Joe Conway wrote:
> > On 06/15/2013 11:28 AM, Alvaro Herrera wrote:
> > > This use case seems too narrow to me to justify the burden of
> > > keeping PGXS-enabled makefiles in contrib.
> >
> > What was the burden of it?
>
> Per http://www.postgresql.org/message-
id/1371093408.309.5.camel@vanquo.pezone.net :
> : 1. take up space
> : 2. confuse users
> : 3. produce broken external extension modules that take contrib as an
> : example 4. break builds of PostgreSQL when users try to fix 3. by
> : exporting USE_PGXS

But:
4. can be fixed (see patches I sent) so it is not an excuse.

I agree for other points.
My only grief is to loose the perfect regression tests for PGXS those contribs
are.

--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: matview incremental maintenance
Next
From: Simon Riggs
Date:
Subject: Re: matview incremental maintenance