Re: Patch for fail-back without fresh backup - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Patch for fail-back without fresh backup
Date
Msg-id 20130615213115.GA7754@awork2.anarazel.de
Whole thread Raw
In response to Re: Patch for fail-back without fresh backup  (Jeff Davis <pgsql@j-davis.com>)
List pgsql-hackers
On 2013-06-15 11:36:54 -0700, Jeff Davis wrote:
> On Fri, 2013-06-14 at 18:27 +0200, Andres Freund wrote:
> > I'd like to see a comment around the memcpys in XLogSaveBufferForHint()
> > that mentions that they are safe in a non std buffer due to
> > XLogCheckBuffer setting an appropriate hole/offset. Or make an explicit
> > change of the copy algorithm there.
> 
> Done.
> Also done.

Thanks! Looks good to me.

> Patch attached. Also, since we branched, I think this should be
> back-patched to 9.3 as well.

Absolutely.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] Remove useless USE_PGXS support in contrib