Re: pgcrypto: Fix RSA password-protected keys - Mailing list pgsql-hackers

From Marko Kreen
Subject Re: pgcrypto: Fix RSA password-protected keys
Date
Msg-id 20130510181654.GA28808@gmail.com
Whole thread Raw
In response to Re: pgcrypto: Fix RSA password-protected keys  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, May 10, 2013 at 12:52:55PM -0400, Tom Lane wrote:
> Marko Kreen <markokr@gmail.com> writes:
> > RSA secret key extraction code uses wrong variable so
> > that decryption is skipped and only secret keys without
> > password work for pgp_pub_decrypt().
> 
> > Attached patch fixes it and also adds regtest.
> 
> > Please apply to all branches.
> 
> Will do, thanks for the fix!

Thanks.

Re: future changelog entry

The problem is specific to RSA keys, password-protected DSA+ElGamal
keys work fine.  Sorry for not mentioning it earlier.

RSA code was added later than ElGamal, and the bug is probably
because of copy-paste from public key code...

-- 
marko




pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: corrupt pages detected by enabling checksums
Next
From: Robert Haas
Date:
Subject: Re: Bug in VACUUM reporting of "removed %d row versions" in 9.2+