Re: Commit subject line - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Commit subject line
Date
Msg-id 20130503181540.GG15498@momjian.us
Whole thread Raw
In response to Re: Commit subject line  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
On Fri, May  3, 2013 at 09:08:08PM +0300, Heikki Linnakangas wrote:
> On 03.05.2013 20:56, Bruce Momjian wrote:
> >On Fri, May  3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote:
> >>
> >>On 05/03/2013 01:23 PM, Bruce Momjian wrote:
> >>>Not sure if I mentioned this, but having first line of the commit be a
> >>>subject has save me lots of time in writing the release notes.  I know
> >>>it is helpful to others too who browse our commits on websites.
> >>>
> >>
> >>
> >>Yeah. The recommended style is to have the first line be 50 chars or
> >>less, which is a bit unfortunate - it can be a challenge to keep to
> >>that limit for a meaningful or comprehensive subject.
> >
> >Yes, I know mine are often cut-off.  What I just did was to add a
> >50-character dashed line to the top of my editor window for commits so I
> >can see the limit each time  --- that should help me.
> 
> Oh, that's tight. I didn't know about the 50 char recommendation.
> I've tried to keep mine < 76 chars, so that when you do "git log",
> it fits on a 80 char display with the 4 char indentation that git
> log does.

Yes, I thought it was <80, but see lots of mine cut off on the website:
http://git.postgresql.org/gitweb/?p=postgresql.git

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Commit subject line
Next
From: Kevin Grittner
Date:
Subject: Re: matview niceties: pick any two of these three