Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Date
Msg-id 20130326202019.GA32088@awork2.anarazel.de
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.  (Kevin Grittner <kgrittn@ymail.com>)
List pgsql-hackers
On 2013-03-26 13:14:53 -0700, Kevin Grittner wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> 
> > Not happy with misc.c as a filename.
> 
> We already have two misc.c files:
> 
> src/backend/utils/adt/misc.c
> src/interfaces/ecpg/ecpglib/misc.c
> 
> I much prefer not to repeat the same filename in different
> directories if we can avoid it.
> 
> > How about pg_dump_utils.c or pg_dump_misc.c?
> 
> Those seem reasonable to me.

I vote against including pg_ in the filename, for an implementation
private file that seems duplicative.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Next
From: Tom Lane
Date:
Subject: Drastic performance loss in assert-enabled build in HEAD