Re: pg_xlogdump - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pg_xlogdump
Date
Msg-id 20130224135904.GB3242@alap2.anarazel.de
Whole thread Raw
In response to Re: pg_xlogdump  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: pg_xlogdump  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2013-02-23 14:54:51 -0800, Jeff Janes wrote:
> If I run "make clean", or "make maintainer-clean", this deletes the file
> contrib/pg_xlogdump/rmgrdesc.c.   And then config/make doesn't know how to
> get it back again.
>
> I don't know if the Makefile needs to be taught not to delete it, or taught
> how to recreate it once deleted.

It shouldn't be deleted, I think neither Alvaro nor me did notice this
because it only matters in non-vpath builds...

Patch attached.

I independently wonder whether we should remove the PGXS stub from
xlogdump, given it relies on a full sourcetree available?

Andres

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: json generation enhancements
Next
From: Stephen Frost
Date:
Subject: Re: Strange Windows problem, lock_timeout test request