Re: BUG #7823: PGDG packaged pgadmin3_92 removes its /usr/bin/pgadmin3 link - Mailing list pgsql-bugs

From Georgi Georgiev
Subject Re: BUG #7823: PGDG packaged pgadmin3_92 removes its /usr/bin/pgadmin3 link
Date
Msg-id 20130203041952.GD14929@jnext-0060.corp.japannext.co.jp
Whole thread Raw
In response to Re: BUG #7823: PGDG packaged pgadmin3_92 removes its /usr/bin/pgadmin3 link  (Georgi Georgiev <georgi-georgiev-pgsql@japannext.co.jp>)
Responses Re: BUG #7823: PGDG packaged pgadmin3_92 removes its /usr/bin/pgadmin3 link
List pgsql-bugs
Quoting Georgi Georgiev at 24/01/2013-12:55:31(+0900):
> Quoting Devrim G=DCND=DCZ at 23/01/2013-21:11:09(+0200):
...
> >=20
> > Should be fixed with 1.16.1-2. Please check.
>=20
> Thanks for the quick turnaround. But there seems to be a typo now, so
> the %post is not working:
....

1.16.1-3 does not throw errors, but it still reliably wipes out the
symlink on an upgrade. A fresh install or a reinstall would create the
symlink, but that is only because the %preun does not run in that case
(there is no old version to "uninstall" in this case).

This can be fixed with a 'if [ "$1" =3D 0 ]; then' in the %preun.

To test all these cases, I used rpmrebuild to create different releases o=
f this
package.

I made a "-2.5" which is identical to -3.
And I made a "-2.8" with the %preun modified like this:

$ rpm -q pgadmin3_92-1.16.1-2.8.rhel6.x86_64  --scripts
postinstall scriptlet (using /bin/sh):
/usr/sbin/update-alternatives --install /usr/bin/pgadmin3 pgadmin3 /usr/p=
gsql-9.2/bin/pgadmin3 920
preuninstall scriptlet (using /bin/sh):
if [ "$1" =3D 0 ]; then
  /usr/sbin/update-alternatives --remove pgadmin3 /usr/pgsql-9.2/bin/pgad=
min3
fi

Test results:

- Upgrade from 2.5 - symlink missing (wrong)
- Upgrade from 2.8 - symlink present (correct)
- Fresh install of any version - symlink present (correct)
- Uninstall any version - symlink missing (correct)

So, please, if you can fix the %preun as above, that should solve all pen=
ding
issues.

--=20
()   Georgi Georgiev   () Writing software is more fun than working. ()
()    Sysadmin Head    ()                                            ()
()   -SBI Japannext-   ()                                            ()

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: postgres 9.2.2 point conversion from polygon doesn't always give accurate center
Next
From: mike@fontling.com
Date:
Subject: BUG #7846: Documentation: Should FOUND be documented as an output of UPDATE statement?