Postgres Pro
Downloads
Home   >   mailing lists

[PATCH] Compile without warning with gcc's -Wtype-limits, -Wempty-body - Mailing list pgsql-hackers

From Andres Freund
Subject [PATCH] Compile without warning with gcc's -Wtype-limits, -Wempty-body
Date
Msg-id 20130114232907.GD22155@awork2.anarazel.de
Whole thread Raw
Responses Re: [PATCH] Compile without warning with gcc's -Wtype-limits, -Wempty-body
List pgsql-hackers
Tree view 
Hi,

the attached trivial patch allows to compile with -Wtype-limits
-Wempty-body (or -Wextra -Wno-unused-parameter -Wno-sign-compare
-Wno-missing-field-initializers).

As the two fixes seem harmless, that seems to be a good idea. And the
recent "bug" (its not really that, but ...) in walsender.c shows that at
least -Wtype-limits is a sensible warning.

Independently from this patch, should we add -Wtype-limits to the
default parameters?

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: s/size_t/off_t/ in sendTimeLineHistory
Next
From: Merlin Moncure
Date:
Subject: Re: json api WIP patch