Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs
Date
Msg-id 20130109144512.GA4490@alvh.no-ip.org
Whole thread Raw
In response to [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs
Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs
List pgsql-hackers
How hard is the backend hit by palloc being now an additional function
call?  Would it be a good idea to make it (and friends) STATIC_IF_INLINE?

> diff --git a/src/include/port/palloc.h b/src/include/port/palloc.h
> new file mode 100644
> index 0000000..a7900bf
> --- /dev/null
> +++ b/src/include/port/palloc.h
> @@ -0,0 +1,19 @@
> +/*
> + *    common.h
> + *        Common support routines for bin/scripts/
> + *
> + *    Copyright (c) 2003-2013, PostgreSQL Global Development Group
> + *
> + *    src/bin/scripts/common.h
> + */

You forgot to update the above comment.


--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade with parallel tablespace copying
Next
From: Magnus Hagander
Date:
Subject: Re: askpass program for libpq