Re: splitting *_desc routines - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: splitting *_desc routines
Date
Msg-id 20121127161022.GJ4227@alvh.no-ip.org
Whole thread Raw
In response to Re: splitting *_desc routines  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: splitting *_desc routines  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Simon Riggs escribió:
> On 23 November 2012 22:52, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> > ./access/rmgrdesc/xact_desc.c
> > ./access/rmgrdesc/heapdesc.c
>
> Could we have either all underscores _ or none at all for the naming?

Sure, removed them all.


Tom Lane escribió:

> FWIW, I'd vote for dumping all of these into *one* rmgrdesc directory
> (which may as well be under access/ since that's where the xlog code is),
> regardless of where the corresponding replay code is in the source tree.
> I don't think splitting them up into half a dozen directories adds
> anything except confusion.  If you want, the header comment for each
> file could mention where the corresponding replay code lives.

Done that way.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: ilist.h fails cpluspluscheck
Next
From: Tom Lane
Date:
Subject: Re: splitting *_desc routines