Re: [PATCH] binary heap implementation - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: [PATCH] binary heap implementation
Date
Msg-id 20121122023951.GA26315@toroid.org
Whole thread Raw
In response to Re: [PATCH] binary heap implementation  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
At 2012-11-21 15:09:12 -0500, robertmhaas@gmail.com wrote:
>
> > The following comments still talk about "key and value", thus need
> > an update:
> 
> Oops.

In the same vein, "Returns NULL if the heap is empty" no longer applies
to binaryheap_first and binaryheap_remove_first. Plus there is an extra
asterisk in the middle of the comment about binaryheap_replace_first.

But it looks good otherwise.

I agree with Tom that we should support resizing the heap, but let's not
bother with that now. I'll write the few extra lines of code the first
time something actually needs to add more elements to a heap.

-- Abhijit



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Removing PD_ALL_VISIBLE
Next
From: Amit Kapila
Date:
Subject: Re: StrategyGetBuffer questions