Re: BUG #7511: 9.2: pg_stat_activity.procpid renamed unnecessarily - Mailing list pgsql-bugs

From Bruce Momjian
Subject Re: BUG #7511: 9.2: pg_stat_activity.procpid renamed unnecessarily
Date
Msg-id 20120830133802.GL8753@momjian.us
Whole thread Raw
In response to BUG #7511: 9.2: pg_stat_activity.procpid renamed unnecessarily  (i@avdd.co)
List pgsql-bugs
On Thu, Aug 30, 2012 at 04:34:18AM +0000, i@avdd.co wrote:
> The following bug has been logged on the website:
>
> Bug reference:      7511
> Logged by:          Adrian Dries
> Email address:      i@avdd.co
> PostgreSQL version: Unsupported/Unknown
> Operating system:   any
> Description:
>
> In trying 9.2 I find pg_stat_activity.procpid has been renamed to pid.
>
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=4f42b546fd87a80be30c53a0f2c897acb826ad52
>
> It seems the premise of this is
>
> If we're going to rename current_query to query--what Scott's patch does
> here--that will force all code using pg_stat_activity to be rewritten. This
> seems like the perfect time to also change "procpid" to "pid", finally blow
> away that wart.
>
> A premise that is untrue: changing a subset of columns on a relation does
> not force "all code" using that relation to be rewritten:
>
>   SELECT procpid FROM pg_stat_activity WHERE procpid <> pg_backend_pid()

True.  We were thinking more of tools that display all pg_stat_activity
columns.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #7511: 9.2: pg_stat_activity.procpid renamed unnecessarily
Next
From: MirrorX
Date:
Subject: Re: hot standby lagging vs warm that is up-to-date